netdev - Re: [PATCH v5] net: sh_eth: Add support of device tree probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <514861EF.7050407@cogentembedded.com>
Date:	Tue, 19 Mar 2013 17:02:39 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Simon Horman <horms@...ge.net.au>
CC:	Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>,
	netdev@...r.kernel.org, grant.likely@...retlab.ca,
	kuninori.morimoto.gx@...esas.com,
	devicetree-discuss@...ts.ozlabs.org, magnus.damm@...il.com,
	kda@...ux-powerpc.org, Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v5] net: sh_eth: Add support of device tree probe

Hello.

On 19-03-2013 8:22, Simon Horman wrote:

>> [ Cc: Mark Rutland ]

>> On Tue, Mar 05, 2013 at 06:52:20AM +0900, Nobuhiro Iwamatsu wrote:
>>> This adds support of device tree probe for Renesas sh-ether driver.

>>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>

>> Hi Iwamatsu-san,

>> could you please address the review by
>> Mark Rutland of the bindings in this patch.
>> The review was made for v2 but I believe it
>> is still applicable to v5.

>> http://www.spinics.net/lists/netdev/msg226454.html

> Ping.

    I don't think converting this driver to device tree can be achieved 
without unravelling the #ifdef mess first (which I'm currently doing).
Or at least the driver will look even uglier than today. So I see little use 
in pinging Iwamatsu-san.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html