netdev - Re: [PATCH v3 net-next 1/5] GRE: Refactor GRE tunneling code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130319.101927.283956963598107880.davem@davemloft.net>
Date:	Tue, 19 Mar 2013 10:19:27 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	netdev@...r.kernel.org, jesse@...ira.com
Subject: Re: [PATCH v3 net-next 1/5] GRE: Refactor GRE tunneling code.

From: Pravin B Shelar <pshelar@...ira.com>
Date: Tue, 19 Mar 2013 01:10:15 -0700

> @@ -0,0 +1,169 @@
> +#ifndef __NET_IP_TUNNELS_H
> +#define __NET_IP_TUNNELS_H 1
> +
> +#include <linux/if_tunnel.h>
> +#include <net/dsfield.h>
> +#include <net/gro_cells.h>
> +#include <net/inet_ecn.h>
> +#include <net/ip.h>
> +
> +/* Keep error state on tunnel for 30 sec */
> +#define IPTUNNEL_ERR_TIMEO	(30*HZ)
> +
> +/* 6rd prefix/relay information */
> +struct ip_tunnel_6rd_parm {
> +	struct in6_addr		prefix;

Please include <linux/in6.h> explicitly rather than getting the in6_addr
definition indirectly via linux/dsfield.h

Please audit the data types and interfaces used in the rest of this
header file and make sure all the proper includes are being explicitly
made.

Finally, if you haven't already, please do some sanity builds with
different combinations of IPV6 being on and off.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html