netdev - Re: [PATCH] fec: Fix the build as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130320191630.GJ20530@pengutronix.de>
Date:	Wed, 20 Mar 2013 20:16:30 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Fabio Estevam <festevam@...il.com>
Cc:	davem@...emloft.net, Frank.Li@...escale.com,
	netdev@...r.kernel.org, Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] fec: Fix the build as module

Hello,

On Wed, Mar 20, 2013 at 03:19:32PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@...escale.com>
> 
> Since commit ff43da86c69 (NET: FEC: dynamtic check DMA desc buff type) the 
> following build error happens when CONFIG_FEC=m
> 
> ERROR: "fec_ptp_init" [drivers/net/ethernet/freescale/fec.ko] undefined!
> ERROR: "fec_ptp_ioctl" [drivers/net/ethernet/freescale/fec.ko] undefined!
> ERROR: "fec_ptp_start_cyclecounter" [drivers/net/ethernet/freescale/fec.ko] undefined!
> 
> Fix it by exporting the required fec_ptp symbols.
IMHO this is not sensible. There is no need to make the fec driver 2
modules. Just loading one is impossible (fec.ko) or useless
(fec_ptp.ko). That's why I suggested to make them a single module.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html