netdev - Re: [PATCH] igb: fix PHC stopping on max freq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1363740552.2069.55.camel@jtkirshe-mobl>
Date:	Tue, 19 Mar 2013 17:49:12 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jiri Benc <jbenc@...hat.com>
Cc:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	Stefan Assmann <sassmann@...hat.com>,
	Miroslav Lichvar <mlichvar@...hat.com>
Subject: Re: [PATCH] igb: fix PHC stopping on max freq

On Tue, 2013-03-19 at 15:42 +0100, Jiri Benc wrote:
> For 82576 MAC type, max_adj is reported as 1000000000 ppb. However, if
> this value is passed to igb_ptp_adjfreq_82576, incvalue overflows out
> of
> INCVALUE_82576_MASK, resulting in setting of zero TIMINCA.incvalue,
> stopping
> the PHC (instead of going at twice the nominal speed).
> 
> Fix the advertised max_adj value to the largest value hardware can
> handle.
> As there is no min_adj value available (-max_adj is used instead),
> this will
> also prevent stopping the clock intentionally. It's probably not a big
> deal,
> other igb MAC types don't support stopping the clock, either.
> 
> Signed-off-by: Jiri Benc <jbenc@...hat.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_ptp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-) 

Thanks Jiri, I have added the patch to my igb queue

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)