[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130320.121412.1230198756594408982.davem@davemloft.net>
Date: Wed, 20 Mar 2013 12:14:12 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: tparkin@...alix.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH 00/12] l2tp bugfix patchset
From: Tom Parkin <tparkin@...alix.com>
Date: Tue, 19 Mar 2013 16:11:11 +0000
> This l2tp bugfix patchset addresses a number of issues.
>
> The first five patches in the series prevent l2tp sessions pinning an l2tp
> tunnel open. This occurs because the l2tp tunnel is torn down in the tunnel
> socket destructor, but each session holds a tunnel socket reference which
> prevents tunnels with sessions being deleted. The solution I've implemented
> here involves adding a .destroy hook to udp code, as discussed previously on
> netdev[1].
>
> The subsequent seven patches address futher bugs exposed by fixing the problem
> above, or exposed through stress testing the implementation above. Patch 11
> (avoid deadlock in l2tp stats update) isn't directly related to tunnel/session
> lifetimes, but it does prevent deadlocks on i386 kernels running on 64 bit
> hardware.
>
> This patchset has been tested on 32 and 64 bit preempt/non-preempt kernels,
> using iproute2, openl2tp, and custom-made stress test code.
>
> [1] http://comments.gmane.org/gmane.linux.network/259169
All applied, thanks for fixing all of these bugs Tom.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists