netdev - Re: [PATCH] dynticks: avoid flow_cache_flush() interrupting every core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130320.132901.1638904507644521607.davem@davemloft.net>
Date:	Wed, 20 Mar 2013 13:29:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	fweisbec@...il.com
Cc:	cmetcalf@...era.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, gilad@...yossef.com,
	sasha.levin@...cle.com, akpm@...ux-foundation.org,
	paulmck@...ux.vnet.ibm.com, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] dynticks: avoid flow_cache_flush() interrupting every
 core

From: Frederic Weisbecker <fweisbec@...il.com>
Date: Wed, 20 Mar 2013 17:37:04 +0100

> 2013/3/20 David Miller <davem@...emloft.net>:
>> From: Chris Metcalf <cmetcalf@...era.com>
>> Date: Tue, 19 Mar 2013 17:35:58 -0400
>>
>>> Previously, if you did an "ifconfig down" or similar on one core, and
>>> the kernel had CONFIG_XFRM enabled, every core would be interrupted to
>>> check its percpu flow list for items that could be garbage collected.
>>>
>>> With this change, we generate a mask of cores that actually have any
>>> percpu items, and only interrupt those cores.  When we are trying to
>>> isolate a set of cpus from interrupts, this is important to do.
>>>
>>> Signed-off-by: Chris Metcalf <cmetcalf@...era.com>
>>> ---
>>> This change stands alone so could be taken into the net tree if
>>> desired, but it is most useful in the context of Frederic Weisbecker's
>>> linux-dynticks work.  So it could be taken up through either tree,
>>> but it certainly needs sign-off from someone familiar with net/core/flow.c.
>>
>> I'm find with this going into the dynticks changes:
>>
>> Acked-by: David S. Miller <davem@...emloft.net>
> 
> At it looks pretty self-contained, can that perhaps go through the
> networking tree?

Fair enough, applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html