netdev - RE: [PATCH net-next] gro: relax ID check in inet_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Mar 2013 20:13:54 +0000
From:	"Dmitry Kravkov" <dmitry@...adcom.com>
To:	Maciej Żenczykowski <maze@...gle.com>,
	"Dmitry Kravkov" <dkravkov@...il.com>
cc:	"Eric Dumazet" <eric.dumazet@...il.com>,
	"David Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Eilon Greenstein" <eilong@...adcom.com>,
	"Pravin B Shelar" <pshelar@...ira.com>,
	"Hsiao-keng Jerry Chu" <hkchu@...gle.com>
Subject: RE: [PATCH net-next] gro: relax ID check in inet_gro_receive()

> -----Original Message-----
> From: Maciej Żenczykowski [mailto:maze@...gle.com]
> Sent: Thursday, March 21, 2013 10:08 PM
> To: Dmitry Kravkov
> Cc: Eric Dumazet; David Miller; netdev@...r.kernel.org; Dmitry Kravkov; Eilon Greenstein; Pravin B Shelar; Hsiao-keng Jerry Chu
> Subject: Re: [PATCH net-next] gro: relax ID check in inet_gro_receive()
> 
> > This is correct: ID only for one of the headers can be handled with current FW/HW, for other DF is set.
> 
> I would prefer for IP ID to be correctly incremented on the inner IPv4
> packet rather than the outer IPv4.
> Could that be changed?

Yes, I will check if it can be done in driver only ...