netdev - Re: [PATCH v2 3/3] sh_eth: use managed device API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130321.173523.2134000966916487176.davem@davemloft.net>
Date:	Thu, 21 Mar 2013 17:35:23 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sergei.shtylyov@...entembedded.com
Cc:	netdev@...r.kernel.org, nobuhiro.iwamatsu.yj@...esas.com
Subject: Re: [PATCH v2 3/3] sh_eth: use managed device API

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Fri, 22 Mar 2013 01:35:51 +0300

> Switch the driver to the managed device API by replacing ioremap() calls with
> devm_ioremap_resource() (which will also result in calling request_mem_region()
> which the driver forgot to do until now) and k[mz]alloc() with devm_kzalloc() --
> this permits to simplify driver's probe()/remove() method cleanup. We can now
> remove the ioremap() error messages since the error messages are printed by
>  devm_ioremap_resource() itself. We can also remove the 'bitbang' field from
> 'struct sh_eth_private' as we don't need it anymore in order to free the memory
> behind it...
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> 
> ---
> Changes since initial posting:
> - removed unused 'mdp' variable in sh_eth_drv_remove().
> 
> Sorry, I seem to have missed the unused variable warning... :-/

I already applied your original patch.

Please read your email before posting new versions of patches.

You have to send me a relative fix since your patches are applied
already.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html