| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Mar 2013 16:49:09 +0900 (JST) From: Masatake YAMATO <yamato@...hat.com> To: bhutchings@...arflare.com Cc: davem@...emloft.net, netdev@...r.kernel.org Subject: Re: [PATCH 1/2] genetlink: trigger BUG_ON if a group name is too long I will look at sparse whether it can capture this kind of mistake. Masatake YAMATO From: Ben Hutchings <bhutchings@...arflare.com> Date: Wed, 20 Mar 2013 17:32:59 +0000 > On Wed, 2013-03-20 at 12:07 -0400, David Miller wrote: >> From: Masatake YAMATO <yamato@...hat.com> >> Date: Tue, 19 Mar 2013 20:47:27 +0900 >> >> > Trigger BUG_ON if a group name is longer than GENL_NAMSIZ. >> > >> > Signed-off-by: Masatake YAMATO <yamato@...hat.com> >> >> Applied, thanks. >> >> Although I'm disappointed that the compiler doesn't say anything about >> this in the assignment. >> >> We're assigning "char[16] = STRING" and it doesn't say anything if the >> final NULL char doesn't fit into the array. > > Unfortunately the C standard says this is allowed. (Though the C++ > standard says it's not!) That doesn't mean the compiler can't warn > about it, of course. > > Ben. > > -- > Ben Hutchings, Staff Engineer, Solarflare > Not speaking for my employer; that's the marketing department's job. > They asked us to note that Solarflare product names are trademarked. > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists