netdev - Re: [PATCH] fec: Unify fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130321094650.GA2341@netboy.at.omicron.at>
Date:	Thu, 21 Mar 2013 10:46:51 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	Fabio Estevam <festevam@...il.com>
Cc:	davem@...emloft.net, Frank.Li@...escale.com,
	u.kleine-koenig@...gutronix.de, netdev@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] fec: Unify fec_ptp.c and fec.c

On Wed, Mar 20, 2013 at 05:11:07PM -0300, Fabio Estevam wrote:

> Move fec_ptp.c code into fec.c and its definitions into fec.h.

...

> +/**
> + * fec_ptp_start_cyclecounter - create the cycle counter from hw
> + * @ndev: network device
> + *
> + * this function initializes the timecounter and cyclecounter
> + * structures for use in generated a ns counter from the arbitrary
> + * fixed point cycles registers in the hardware.
> + */
> +void fec_ptp_start_cyclecounter(struct net_device *ndev)
> +{

This function and the other, previously global functions should now be
changed to 'static'.

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html