netdev - Re: [PATCH] fec: Unify fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130321100949.GO20530@pengutronix.de>
Date:	Thu, 21 Mar 2013 11:09:49 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Frank Li <lznuaa@...il.com>
Cc:	Fabio Estevam <festevam@...il.com>, davem@...emloft.net,
	Frank.Li@...escale.com, netdev@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] fec: Unify fec_ptp.c and fec.c

Hello,

On Thu, Mar 21, 2013 at 06:02:02PM +0800, Frank Li wrote:
> I suggest use below patch to fix this problem
> 
> --- a/drivers/net/ethernet/freescale/Makefile
> +++ b/drivers/net/ethernet/freescale/Makefile
> @@ -2,7 +2,8 @@
>  # Makefile for the Freescale network device drivers.
>  #
> 
> -obj-$(CONFIG_FEC) += fec.o fec_ptp.o
> +obj-$(CONFIG_FEC) += fec_driver.o
> +fec_driver-objs := fec.o fec_ptp.o
>  obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx.o
>  ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y)
>         obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.o
I thought about suggesting something similar, too. I would have renamed
fec.c to (say) fec_base.c and then kept the module name fec.ko. Not sure
keeping the module name is critical.

What is missing from your patch is dropping the EXPORT_SYMBOLs. Other
than that I like it better than using a single .c file.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html