netdev - Re: [PATCH 1/1]core:Change a wrong explain about dev_get_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1364002324.4431.84.camel@edumazet-glaptop>
Date:	Fri, 22 Mar 2013 18:32:04 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	tingwei liu <tingw.liu@...il.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>, netdev@...r.kernel.org,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>, davem@...emloft.net
Subject: Re: [PATCH 1/1]core:Change a wrong explain about dev_get_by_name

On Sat, 2013-03-23 at 09:24 +0800, tingwei liu wrote:
> On Thu, Mar 21, 2013 at 1:43 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> > On Wed, 2013-03-20 at 17:10 +0000, Ben Hutchings wrote:
> >
> >> If they are wrongly documented as 'can be called from any context', yes.
> >
> > Wow, thats really useful.
> >
> > Why is this function not allowed from hard irq context, we have no idea.
> When function "list_netdevice" get write lock "dev_base_lock" only
> disable soft interrupt. So dev_get_by_name get read lock
> "dev_base_lock", can not called on interrupt context.


dev_get_by_name() doesn't read lock dev_base_lock
since commit 72c9528bab94cc052

This was back to linux-2.6.33

Are you sending patches for older kernel versions per chance ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html