netdev - Re: [PATCH net-next] ip_gre: increase inner ip header ID only for IPv4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALnjE+qTr5LxozvmN2yBZMN88ra6SVchHcmbgMXhh0cG1ZM41w@mail.gmail.com>
Date:	Sat, 23 Mar 2013 21:13:09 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Cong Wang <amwang@...hat.com>
Cc:	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] ip_gre: increase inner ip header ID only for IPv4

On Sat, Mar 23, 2013 at 7:37 PM, Cong Wang <amwang@...hat.com> wrote:
> On Sat, 2013-03-23 at 16:36 -0700, Pravin Shelar wrote:
>> On Fri, Mar 22, 2013 at 10:29 PM, Cong Wang <amwang@...hat.com> wrote:
>> > From: Cong Wang <amwang@...hat.com>
>> >
>> > Pravin pointed out the inner network header of a GRE tunnel packet
>> > could be IPv6, where there is no ID. So we should check the version.
>> >
>>
>> inet_gso_segment() already increment ip-header identification. What is
>> problem with that?
>
> Let tcpdump speak:
>
> (Inner ID is always 3b65 without my patch)
>
Thanks for report.
I just sent out fix, Can you please try that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html