netdev - Re: [PATCH 0/2] Fix for mv643xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130324.170726.2271831814087007906.davem@davemloft.net>
Date:	Sun, 24 Mar 2013 17:07:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	florian@...nwrt.org
Cc:	gmbnomis@...il.com, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	thomas.petazzoni@...e-electrons.com, jason@...edaemon.net,
	andrew@...n.ch
Subject: Re: [PATCH 0/2] Fix for mv643xx_eth built as module

From: Florian Fainelli <florian@...nwrt.org>
Date: Sun, 24 Mar 2013 21:48:33 +0100

> Hello Simon,
> 
> Le dimanche 24 mars 2013 21:33:58, Simon Baatz a écrit :
>> Recently [1], mv643xx_eth was changed to make use of mvmdio. However,
>> this change introduces two problems when mvmdio and mv643xx_eth are
>> built as modules:
>> 
>> - mvmdio is not loaded automatically by udev
>> - mv643xx_eth oopses when it can't find its PHY, i.e. when mvmdio is
>>   not yet loaded
>> 
>> The first problem can be fixed easily by adding a module alias for the
>> respective platform device.  The proposed fix for the second problem
>> uses EPROBE_DEFER as suggested by Thomas Petazzoni when the driver
>> can't find its PHY.
>> 
>> These patches apply on top of Florian Fainelli's patchset. They have
>> been tested on Marvel Kirkwood non-DT.
> 
> Both fixes look good to me, thanks for fixing this!
> 
> Acked-by: Florian Fainelli <florian@...nwrt.org>

All applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html