netdev - Re: [PATCH] net: remove a WARN_ON() in net_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130324.172750.346803352885480915.davem@davemloft.net>
Date:	Sun, 24 Mar 2013 17:27:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, chavey@...gle.com
Subject: Re: [PATCH] net: remove a WARN_ON() in net_enable_timestamp()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 22 Mar 2013 17:38:28 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> The WARN_ON(in_interrupt()) in net_enable_timestamp() can get false
> positive, in socket clone path, run from softirq context :
 ...
> Its safe at this point because the parent socket owns a reference
> on the netstamp_needed, so we cant have a 0 -> 1 transition, which
> requires to lock a mutex.
> 
> Instead of refining the check, lets remove it, as all known callers
> are safe. If it ever changes in the future, static_key_slow_inc()
> will complain anyway.
> 
> Reported-by: Laurent Chavey <chavey@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html