netdev - Re: [PATCH net-next] ptp: increase the maximum number of clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1364247596.2710.18.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Mon, 25 Mar 2013 21:39:56 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Richard Cochran <richardcochran@...il.com>
CC:	Jiri Benc <jbenc@...hat.com>, David Miller <davem@...emloft.net>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] ptp: increase the maximum number of clocks

On Mon, 2013-03-25 at 19:51 +0100, Richard Cochran wrote:
> On Mon, Mar 25, 2013 at 05:08:55PM +0100, Jiri Benc wrote:
> > On Sat, 23 Mar 2013 18:59:15 +0100, Richard Cochran wrote:
> > > Jiri, do you want to work on making the number of clocks essentially
> > > unlimited? If not, I can take a look at this, but not right away.
> > 
> > I'm currently thinking of using just /dev/ptp for all PHCs in the
> > system and specifying the desired network device (ifindex, likely)
> > by an ioctl as the very first operation. What do you think? If this
> > is viable, I can try to implement it.
> 
> While that might work for the PTP ioctls, it won't for the main
> clock_gettime/settime/adjtime call. As you wrote below, these take a
> dynamic clockid_t (which comes from a file descriptor), and so each
> device needs its own, unique file system node.
> 
> For better or worse, we are stuck with char devs, unless we want to
> redo the clock_xyz API. I certainly don't want to. We can have over a
> million PTP clocks on a single major number. That should be enough.
> 
> IIRC, it is possible to grow the range of minor numbers
> incrementally. Perhaps you could take a look at that?

MTD used to have a static table of devices, which was a problem for the
sfc driver as it exposes multiple partitions on each NIC through MTD.
It was reasonably easy to switch to dynamic numbering using the idr
library, and I expect that would also work for PTP clock devices.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html