netdev - Re: [PATCH] drivers/isdn: break out of the loop after call isdn_tty_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <514FC42A.3030807@asianux.com>
Date:	Mon, 25 Mar 2013 11:27:38 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Jiri Kosina <jkosina@...e.cz>
CC:	Jiri Slaby <jslaby@...e.cz>, David Miller <davem@...emloft.net>,
	isdn@...ux-pingi.de, Greg KH <gregkh@...uxfoundation.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] drivers/isdn: break out of the loop after call isdn_tty_send_msg

Hello Jiri Kosina:

  could you help to check this patch whether is OK ?

  thanks.

  :-)

gchen.


On 2013年03月20日 13:03, Chen Gang wrote:
> Hello Maintainers:
> 
>   did I send incorrect mail address ?
>     ./scripts/get_maintainers.pl leads to cc netdev, but exclude David Miller.
>     is it a bug of ./scripts/get_maintainers.pl ?
>       (this time, I include him in this mail address).
> 
>   welcome any members to providing suggestions or completions.
> 
>   thanks.
> 
> gchen.
> 
> On 2013年03月15日 10:02, Chen Gang wrote:
>> Hello Maintainers:
>>
>>   is it qualified to be applied ?
>>
>>   thanks.
>>
>>
>> 于 2013年02月28日 17:54, Jiri Slaby 写道:
>>> On 02/28/2013 03:57 AM, Chen Gang wrote:
>>>>
>>>>   need break out of the loop after call isdn_tty_send_msg.
>>>>     isdn_tty_send_msg is intended to eat the rest of the string.
>>>>     so need not scan again the string which appended "+M...".
>>>
>>> Yes, looks good.
>>>
>>>> Signed-off-by: Chen Gang <gang.chen@...anux.com>
>>>> ---
>>>>  drivers/isdn/i4l/isdn_tty.c |    4 +++-
>>>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c
>>>> index d8a7d83..8ac7b33 100644
>>>> --- a/drivers/isdn/i4l/isdn_tty.c
>>>> +++ b/drivers/isdn/i4l/isdn_tty.c
>>>> @@ -3587,7 +3587,7 @@ isdn_tty_parse_at(modem_info *info)
>>>>  			case 'M':	/* MESSAGE */
>>>>  				p++;
>>>>  				isdn_tty_send_msg(info, m, p);
>>>> -				break;
>>>> +				goto tail;
>>>>  			default:
>>>>  				PARSE_ERROR;
>>>>  			}
>>>> @@ -3601,6 +3601,8 @@ isdn_tty_parse_at(modem_info *info)
>>>>  			PARSE_ERROR;
>>>>  		}
>>>>  	}
>>>> +
>>>> +tail:
>>>>  #ifdef CONFIG_ISDN_AUDIO
>>>>  	if (!info->vonline)
>>>>  #endif
>>>>
>>>
>>>
>>
>>
> 
> 


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html