netdev - Re: [PATCH net-next] bridge: avoid br_ifinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51506DFE.4040405@cogentembedded.com>
Date:	Mon, 25 Mar 2013 19:32:14 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	David Miller <davem@...emloft.net>
CC:	honkiko@...il.com, netdev@...r.kernel.org,
	bridge@...ts.linux-foundation.org, stephen@...workplumber.org,
	herbert@...dor.hengli.com.au, zhiguo.hong@....com
Subject: Re: [PATCH net-next] bridge: avoid br_ifinfo_notify when nothing
 changed

Hello.

On 25-03-2013 1:15, David Miller wrote:

>>> When neither IFF_BRIDGE nor IFF_BRIDGE_PORT is set,
>>> and afspec == NULL but  protinfo != NULL, we run into
>>> "if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p);" with
>>> random value in ret.

>>> Thanks to Sergei for pointing out the error in commit comments.

>>> Signed-off-by: Hong Zhiguo <honkiko@...il.com>

>>      For the future, if you post the revised version of the patch, you
>> should indicate in the subject it like this: [PATCH v2].

> I'm disappointed that you have enough energy to point out such a lower
> priority omission, but you lack the time for something more important,
> which is giving this patch your explicit ACK if it fixes all of the
> issues you pointed out to him.

    Sorry, I don't usuallly ACK patches in an area I'm not closely familiar 
with. Though I can add:

Reviewed-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html