netdev - Re: [PATCH net-next 1/1] net: fec: TX Buffer incorrectly initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130326.121254.2235859772172542379.davem@davemloft.net>
Date:	Tue, 26 Mar 2013 12:12:54 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	jim_baxter@...tor.com, Frank.Li@...escale.com,
	fabio.estevam@...escale.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/1] net: fec: TX Buffer incorrectly
 initialized

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 26 Mar 2013 08:44:04 -0700

> On Tue, 2013-03-26 at 15:25 +0000, Jim Baxter wrote:
>> The TX Buffer in fec_enet_alloc_buffers was being initialized
>> with the receive register define BD_ENET_RX_INT instead of
>> the transmit register define BD_ENET_TX_INT
>> 
>> Signed-off-by: Jim Baxter <jim_baxter@...tor.com>
>> ---
>>  drivers/net/ethernet/freescale/fec_main.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
>> index 3eb608f..2b78a1e 100644
>> --- a/drivers/net/ethernet/freescale/fec_main.c
>> +++ b/drivers/net/ethernet/freescale/fec_main.c
>> @@ -1391,7 +1391,7 @@ static int fec_enet_alloc_buffers(struct net_device *ndev)
>>  
>>  		if (fep->bufdesc_ex) {
>>  			struct bufdesc_ex *ebdp = (struct bufdesc_ex *)bdp;
>> -			ebdp->cbd_esc = BD_ENET_RX_INT;
>> +			ebdp->cbd_esc = BD_ENET_TX_INT;
>>  		}
>>  
>>  		bdp = fec_enet_get_nextdesc(bdp, fep->bufdesc_ex);
> 
> I am curious. What is the point having cbd_esc ?
> 
> Its a written only field.

It's read by the chip and this is how the chip decides what interrupts
to generate when the descriptor is fully processed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html