netdev - Re: [PATCH net-next] VXLAN: Precompute vin for VXLAN header.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALnjE+pZyaP=PpRiwDq0aWzXoQ7WDVN+kOp8jkfvbzzbK0UVVA@mail.gmail.com>
Date:	Tue, 26 Mar 2013 12:02:12 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	David Stevens <dlstevens@...ibm.com>
Cc:	davem@...emloft.net, jesse@...ira.com, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net-next] VXLAN: Precompute vin for VXLAN header.

On Tue, Mar 26, 2013 at 11:43 AM, David Stevens <dlstevens@...ibm.com> wrote:
> netdev-owner@...r.kernel.org wrote on 03/26/2013 02:28:59 PM:
>  Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
>
>> @@ -1006,7 +1004,7 @@ static netdev_tx_t vxlan_xmit_one(struct
>> sk_buff *skb, struct net_device *dev,
>>
>>     vxh = (struct vxlanhdr *) __skb_push(skb, sizeof(*vxh));
>>     vxh->vx_flags = htonl(VXLAN_FLAGS);
>> -   vxh->vx_vni = htonl(vni << 8);
>> +   vxh->vx_vni = vxlan->vni;
>
>         This is not correct since vni != vxlan->vni if an alternate
> vni is specified via the fdb entry. You would need to also store
> the fdb vni's as htonl(vni<<<8) and translate those back for netlink
> dump operations, too.
>
>                                                         +-DLS
>
Right I missed fdb vin , Let me send updated patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html