netdev - Re: [PATCH v2] yam: remove redundant null check on dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130327.143109.1828472656521608702.davem@davemloft.net>
Date:	Wed, 27 Mar 2013 14:31:09 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	colin.king@...onical.com
Cc:	jpr@...bb.org, linux-hams@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] yam: remove redundant null check on dev

From: Colin King <colin.king@...onical.com>
Date: Wed, 27 Mar 2013 18:25:04 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> yam_open has a redundant null check on null,  it will
> never be called with dev == NULL. Remove this redundant check.
> This also cleans up a smatch warning:
> 
> drivers/net/hamradio/yam.c:869 yam_open() warn: variable
>   dereferenced before check 'dev' (see line 867)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html