netdev - Re: [PATCH -next] GRE: Use strlcat() for size checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130327.161015.2272912627472653661.davem@davemloft.net>
Date:	Wed, 27 Mar 2013 16:10:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	geert@...ux-m68k.org, pshelar@...ira.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org
Subject: Re: [PATCH -next] GRE: Use strlcat() for size checking

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 27 Mar 2013 20:06:16 +0000

> On Wed, 2013-03-27 at 19:48 +0100, Geert Uytterhoeven wrote:
>> On m68k, gcc tries to be smart and turns
>> 
>>     strncat(name, "%d", 2);
>> 
>> into a call to strlen() and a 16-bit store, causing a link failure,
>> as arch/m68k/include/asm/string.h provides strlen() using a macro:
>> 
>>     ERROR: "strlen" [net/ipv4/ip_tunnel.ko] undefined!
> 
> Perhaps you should fix the string library for m68k, then!

Right, this symbol really must be provided.

You cannot merely provide inlines.

The off-by-one error is seperate, but that should be fixed
differently.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html