netdev - Re: [PATCH] ptp_pch: eliminate a number of sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+KhAHa+Lu26EX2JsZsf3pMb65w7khbAnz=reXGrvV1z71Up0g@mail.gmail.com>
Date:	Wed, 27 Mar 2013 13:59:06 +0900
From:	Keun-O Park <kpark3469@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	richardcochran@...il.com, keun-o.park@...driver.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] ptp_pch: eliminate a number of sparse warnings

On Wed, Mar 27, 2013 at 1:51 PM, David Miller <davem@...emloft.net> wrote:
> From: kpark3469@...il.com
> Date: Wed, 27 Mar 2013 13:45:12 +0900
>
>> -module_param_string(station, pch_param.station, sizeof pch_param.station, 0444);
>> +module_param_string(station,
>> +      pch_param.station, sizeof(pch_param.station), 0444);
>
> Function arguments on the second and subsequent line of a function
> call should line up with the first column after the colum of the
> openning parenthesis of the first line.
>
> Don't just use TAB characters exclusively, the above looks
> incredibly ugly.  Instead use the necessary combination of
> TAB and space characters necessary to make the argument
> line up at the correct column so it all lines up and looks
> nice.

Ah.. okay. I see.
Thanks.

-- kpark
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html