lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Mar 2013 15:35:52 +0800 From: dingtianhong <dingtianhong@...wei.com> To: Eric Dumazet <eric.dumazet@...il.com> CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, <netdev@...r.kernel.org>, Li Zefan <lizefan@...wei.com>, Xinwei Hu <huxinwei@...wei.com> Subject: [PATCH] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL On 2013/3/26 21:46, Eric Dumazet wrote: > On Tue, 2013-03-26 at 19:35 +0800, dingtianhong wrote: > >> I think if not call scm_set_creds(), the credential would useles in recvmsg(). >> we could remove code: >> if (check_creds) { >> /* Never glue messages from different writers */ >> if ((UNIXCB(skb).pid != siocb->scm->pid) || >> (UNIXCB(skb).cred != siocb->scm->cred)) >> break; >> } else { >> /* Copy credentials */ >> scm_set_cred(siocb->scm, UNIXCB(skb).pid, UNIXCB(skb).cred); >> check_creds = 1; >> } > > Are you paraphrasing me or saying something different ? > if not call scm_set_creds(), how get credentials for receiver and distinguish different writes, so I think scm_set_creds() is necessary here. > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists