netdev - Re: [net-next PATCH 1/2] drivers: net: ethernet: cpsw: use netif_wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1364396142.15753.10.camel@edumazet-glaptop>
Date:	Wed, 27 Mar 2013 07:55:42 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Mugunthan V N <mugunthanvnm@...com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	linux-omap@...r.kernel.org
Subject: Re: [net-next PATCH 1/2] drivers: net: ethernet: cpsw: use
 netif_wake_queue() while restarting tx queue

On Wed, 2013-03-27 at 20:11 +0530, Mugunthan V N wrote:
> To restart tx queue use netif_wake_queue() intead of netif_start_queue()
> so that net schedule will restart transmission immediately which will
> increase network performance while doing huge data transfers.
> 
> Reported-by: Dan Franke <dan.franke@...neider-electric.com>
> Suggested-by: Sriramakrishnan A G <srk@...com>
> Signed-off-by: Mugunthan V N <mugunthanvnm@...com>
> ---
>  drivers/net/ethernet/ti/cpsw.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index f4be85b..61ecebf 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -458,7 +458,7 @@ static void cpsw_tx_handler(void *token, int len, int status)
>  	 * queue is stopped then start the queue as we have free desc for tx
>  	 */
>  	if (unlikely(netif_queue_stopped(ndev)))
> -		netif_start_queue(ndev);
> +		netif_wake_queue(ndev);
>  	cpts_tx_timestamp(priv->cpts, skb);
>  	priv->stats.tx_packets++;
>  	priv->stats.tx_bytes += len;


Its a bug fix, suitable for net tree

Acked-by: Eric Dumazet <edumazet@...gle.com>

BTW, it seems cpsw_ndo_start_xmit() can race with cpsw_tx_handler().



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html