netdev - Re: [PATCH] net : Fix broken IPv6 routing table after loopback down-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1364398008.15753.14.camel@edumazet-glaptop>
Date:	Wed, 27 Mar 2013 08:26:48 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Cc:	Balakumaran Kannan <kumaran.4353@...il.com>, davem@...emloft.net,
	kuznet@....inr.ac.ru, jmorris@...ei.org, kaber@...sh.net,
	netdev@...r.kernel.org, Balakumaran.Kannan@...sony.com,
	maruthi.thotad@...sony.com
Subject: Re: [PATCH] net : Fix broken IPv6 routing table after loopback
 down-up

On Wed, 2013-03-27 at 19:55 +0900, YOSHIFUJI Hideaki wrote:
> Balakumaran Kannan wrote:

> >  	add_addr(idev, &in6addr_loopback, 128, IFA_HOST);
> > +
> > +	while ((sp_dev = dev_get_by_index(dev_net(dev), i++))) {
> > +
> 
> I think this cannot work because we may have missing index.
> Why no dev_get_by_name()?

I might 'work' because lo interface index is 1 on all network
namespaces.

But yes, this ugly loop is not needed at all.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html