netdev - Re: [PATCH 4/6] gdm72xx: replace obsolete NLMSG_* with type safe nlmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130328143709.GE23043@casper.infradead.org>
Date:	Thu, 28 Mar 2013 14:37:09 +0000
From:	Thomas Graf <tgraf@...g.ch>
To:	Hong Zhiguo <honkiko@...il.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [PATCH 4/6] gdm72xx: replace obsolete NLMSG_* with type safe
 nlmsg_*

On 03/28/13 at 12:52am, Hong Zhiguo wrote:
> Signed-off-by: Hong Zhiguo <honkiko@...il.com>
> ---
>  drivers/staging/gdm72xx/netlink_k.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/gdm72xx/netlink_k.c b/drivers/staging/gdm72xx/netlink_k.c
> index 52c25ba..c1239aa 100644
> --- a/drivers/staging/gdm72xx/netlink_k.c
> +++ b/drivers/staging/gdm72xx/netlink_k.c
> @@ -25,12 +25,12 @@
>  
>  #define ND_MAX_GROUP			30
>  #define ND_IFINDEX_LEN			sizeof(int)
> -#define ND_NLMSG_SPACE(len)		(NLMSG_SPACE(len) + ND_IFINDEX_LEN)
> +#define ND_NLMSG_SPACE(len)		(nlmsg_total_size(len) + ND_IFINDEX_LEN)
>  #define ND_NLMSG_DATA(nlh) \
> -	((void *)((char *)NLMSG_DATA(nlh) + ND_IFINDEX_LEN))
> +	((void *)((char *)nlmsg_data(nlh) + ND_IFINDEX_LEN))
>  #define ND_NLMSG_S_LEN(len)		(len+ND_IFINDEX_LEN)
>  #define ND_NLMSG_R_LEN(nlh)		(nlh->nlmsg_len-ND_IFINDEX_LEN)
> -#define ND_NLMSG_IFIDX(nlh)		NLMSG_DATA(nlh)
> +#define ND_NLMSG_IFIDX(nlh)		nlmsg_data(nlh)
>  #define ND_MAX_MSG_LEN			8096

This is not pretty at all but outside of the context of your patch.

Acked-by: Thomas Graf <tgraf@...g.ch>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html