netdev - Re: [PATCH net-next] net: fix compile error of implicit declaration of skb_probe_transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130327.232213.1286089823569084478.davem@davemloft.net>
Date:	Wed, 27 Mar 2013 23:22:13 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jasowang@...hat.com
Cc:	ying.xue@...driver.com, netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net-next] net: fix compile error of implicit
 declaration of skb_probe_transport_header

From: Jason Wang <jasowang@...hat.com>
Date: Thu, 28 Mar 2013 11:12:06 +0800

> On 03/28/2013 10:46 AM, Ying Xue wrote:
>> The commit 40893fd(net: switch to use skb_probe_transport_header())
>> involes a new error accidently. When NET_SKBUFF_DATA_USES_OFFSE is
>> not enabled, below compile error happens:
>>
>>   CC      net/packet/af_packet.o
>>   net/packet/af_packet.c: In function ‘packet_sendmsg_spkt’:
>>   net/packet/af_packet.c:1516:2: error: implicit declaration of function ‘skb_probe_transport_header’ [-Werror=implicit-function-declaration]
>>   cc1: some warnings being treated as errors
>>   make[2]: *** [net/packet/af_packet.o] Error 1
>>   make[1]: *** [net/packet] Error 2
>>   make: *** [net] Error 2
>>
>> As it seems skb_probe_transport_header() is not related to
>> NET_SKBUFF_DATA_USES_OFFSE, we should move the definition of
>> skb_probe_transport_header() out of scope of
>> NET_SKBUFF_DATA_USES_OFFSE macro.
>>
>> Cc: Jason Wang <jasowang@...hat.com>
>> Cc: Eric Dumazet <edumazet@...gle.com>
>> Signed-off-by: Ying Xue <ying.xue@...driver.com>
>> ---
>>  include/linux/skbuff.h |   26 +++++++++++++-------------
>>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> Oops.
> 
> Acked-by: Jason Wang <jasowang@...hat.com>

Applied, thanks.