netdev - Re: [PATCH 1/2] sky2: Receive Overflows not counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130329.145252.765794718423253074.davem@davemloft.net>
Date:	Fri, 29 Mar 2013 14:52:52 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	mlindner@...vell.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] sky2: Receive Overflows not counted

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Thu, 28 Mar 2013 14:40:20 -0700

>> The sky2 driver doesn't count the Receive Overflows because the MAC 
>> interrupt for this event is not set in the MAC's interrupt mask.
>> The MAC's interrupt mask is set only for Transmit FIFO Underruns.
>> 
>> Fix: The correct setting should be (GM_IS_TX_FF_UR | GM_IS_RX_FF_OR)
>> Otherwise the Receive Overflow event will not generate any interrupt.
>> The  Receive Overflow interrupt is handled correctly
>> 
>> Signed-off-by: Mirko Lindner <mlindner@...vell.com>
> 
> Both these patches are fine, but the patch format seems corrupted since
> they won't directly apply with quilt.
> 
> Acked-by: Stephen Hemminger <stephen@...workplumber.org>

They apply cleanly to the 'net' tree just fine, I don't know why
it didn't work for you.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html