netdev - Re: [PATCH 1/2 v3] usbnet: allow status interrupt URB to always be active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130329.152043.1285405417950961484.davem@davemloft.net>
Date:	Fri, 29 Mar 2013 15:20:43 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dcbw@...hat.com
Cc:	oliver@...kum.org, epasheva@...rrawireless.com,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	rfiler@...rrawireless.com, phil@....cc
Subject: Re: [PATCH 1/2 v3] usbnet: allow status interrupt URB to always be
 active

From: Dan Williams <dcbw@...hat.com>
Date: Thu, 28 Mar 2013 11:30:07 -0500

> +	if (test_bit (EVENT_DEV_ASLEEP, &dev->flags))
> +		return -EINVAL;
> +
> +	mutex_lock (&dev->interrupt_mutex);

Please do not put a space between a function name and the openning
parenthesis in the call.

These are not C language primitives (where the space would be
appropriate, f.e. "if (") they are C functions.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html