netdev - Re: [PATCH] net: core: Remove redundant call to 'nf_reset' in 'dev_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130329.152606.1390301950426444505.davem@davemloft.net>
Date:	Fri, 29 Mar 2013 15:26:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	shmulik.ladkani@...il.com, greearb@...delatech.com,
	netdev@...r.kernel.org, rgohita@...il.com
Subject: Re: [PATCH] net: core: Remove redundant call to 'nf_reset' in
 'dev_forward_skb'

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 29 Mar 2013 12:17:36 -0700

> On Fri, 2013-03-29 at 15:11 -0400, David Miller wrote:
>> From: Shmulik Ladkani <shmulik.ladkani@...il.com>
>> Date: Thu, 28 Mar 2013 11:13:26 +0200
>> 
>> > 'nf_reset' is called just prior calling 'netif_rx'.
>> > No need to call it twice.
>> > 
>> > Reported-by: Igor Michailov <rgohita@...il.com>
>> > Signed-off-by: Shmulik Ladkani <shmulik.ladkani@...il.com>
>> 
>> I do not see this happening in the:
>> 
>> 	macvlan_start_xmit()
>> 
>> 		 --> macvlan_queue_xmit()
>> 
>> code path.
>> 
>> I'm not applying this patch.  There seems to be no real agreement
>> that the caller of dev_forward_skb() takes care of the nf_reset().
>> 
>> And wouldn't it be better to consolidate the nf_reset() calls
>> into one place instead of several, increasing the audit burdon.
>> 
> 
> Hmm, I believe you misread this patch :
> 
> nf_reset() is called _twice_ in dev_forward_skb()

Aha, that makes more sense, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html