netdev - Re: [PATCH v2] include/linux: printk is needed in filter.h when CONFIG_BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130329.153447.426374969178935845.davem@davemloft.net>
Date:	Fri, 29 Mar 2013 15:34:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	gang.chen@...anux.com
Cc:	edumazet@...gle.com, dborkman@...hat.com, wad@...omium.org,
	eparis@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] include/linux: printk is needed in filter.h when
 CONFIG_BPF_JIT is defined

From: Chen Gang <gang.chen@...anux.com>
Date: Fri, 29 Mar 2013 09:24:53 +0800

> 
>   for make V=1 EXTRA_CFLAGS=-W ARCH=arm allmodconfig
>     printk is need when CONFIG_BPF_JIT is defined
>     or it will report pr_err and print_hex_dump are implicit declaration
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>

There are no references to pr_err nor print_hex_dump in this
filter.h header file.

I think the issue is more like that the ARM bpf jit code uses
those routines, and therefore the ARM bpf jit code is what needs
to add these includes.

I'm not applying this patch, it isn't correct.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html