netdev - Re: [PATCH net-next] audit: pass int* to nlmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 Mar 2013 18:54:09 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Alexandru Copot <alex.mihai.c@...il.com>
CC:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	davem@...emloft.net, honkiko@...il.com, tgraf@...g.ch
Subject: Re: [PATCH net-next] audit: pass int* to nlmsg_next

Hello.

On 29-03-2013 1:31, Alexandru Copot wrote:

> Commit 941912133025926307c7a65b203fa38403b1063a

    Please also specify the summary line of that commit in parens (or however 
you like).
    With that, you can add my:

Acked-by: Sergei Shtylyov <segei.shtylyov@...entembedded.com>

> replaced the macros
> NLMSG_NEXT with calls to nlmsg_next which produces this warning:

> kernel/audit.c: In function ‘audit_receive_skb’:
> kernel/audit.c:928:3: warning: passing argument 2 of ‘nlmsg_next’ makes pointer from integer without a cast
> In file included from include/net/rtnetlink.h:5:0,
>                   from include/net/neighbour.h:28,
>                   from include/net/dst.h:17,
>                   from include/net/sock.h:68,
>                   from kernel/audit.c:55:
> include/net/netlink.h:359:1: note: expected ‘int *’ but argument is of type ‘int’

> Fix this by sending the intended pointer.

> Signed-off-by: Alexandru Copot <alex.mihai.c@...il.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html