netdev - Re: [PATCH net-next] macvlan: use the right RCU api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130330.173200.1869970263303871433.davem@davemloft.net>
Date:	Sat, 30 Mar 2013 17:32:00 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] macvlan: use the right RCU api

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 30 Mar 2013 13:08:44 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Make sure we use proper API to fetch dev->rx_handler_data,
> instead of ugly casts.
> 
> Rename macvlan_port_get() to macvlan_port_get_rtnl() to document fact
> that we hold RTNL when needed, with lockdep support.
> 
> This removes sparse warnings as well (CONFIG_SPARSE_RCU_POINTER=y)
> 
> CHECK   drivers/net/macvlan.c
> drivers/net/macvlan.c:706:37: warning: cast removes address space of expression
> drivers/net/macvlan.c:775:16: warning: cast removes address space of expression
> drivers/net/macvlan.c:924:16: warning: cast removes address space of expression
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html