netdev - Re: [Suggestion] drivers/isdn/divert: break looping, or memory leak by calling kmalloc again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51595C9A.1060608@imap.cc>
Date:	Mon, 01 Apr 2013 12:08:26 +0200
From:	Tilman Schmidt <tilman@...p.cc>
To:	Chen Gang <gang.chen@...anux.com>
CC:	isdn@...ux-pingi.de, Jiri Slaby <jslaby@...e.cz>,
	Jiri Kosina <jkosina@...e.cz>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [Suggestion] drivers/isdn/divert: break looping, or memory leak
 by calling kmalloc again

Am 01.04.2013 04:11, schrieb Chen Gang:
> in drivers/isdn/divert/isdn_divert.c:
> 
>   in 'for' looping (line 395..515)
>     the 'cs' may call kmalloc again (line 453).
> 
>   it seems need break looping, when get valid 'cs' value (line 509)

I don't think so. If the kmalloc for cs succeeds, control flow will
continue linearly up to the 'if' statement in line 503. Then it will
either kfree(cs) and return, or reach the 'break' in line 514 which
will end the 'for' loop.

HTH
Tilman

-- 
Tilman Schmidt                    E-Mail: tilman@...p.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


Download attachment "signature.asc" of type "application/pgp-signature" (262 bytes)