netdev - Re: [PATCH] drivers/isdn/divert: beautify code, delete useless 'break'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <515993E1.5010508@cogentembedded.com>
Date:	Mon, 01 Apr 2013 18:04:17 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Chen Gang <gang.chen@...anux.com>
CC:	isdn@...ux-pingi.de, Jiri Slaby <jslaby@...e.cz>,
	'Jiri Kosina' <trivial@...nel.org>, tilman@...p.cc,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org >> netdev" <netdev@...r.kernel.org>
Subject: Re: [PATCH] drivers/isdn/divert: beautify code, delete useless 'break'

Hello.

On 01-04-2013 5:52, Chen Gang wrote:

>    delete useless break statements.

> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>   drivers/isdn/divert/isdn_divert.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)

> diff --git a/drivers/isdn/divert/isdn_divert.c b/drivers/isdn/divert/isdn_divert.c
> index db432e6..76d505e 100644
> --- a/drivers/isdn/divert/isdn_divert.c
> +++ b/drivers/isdn/divert/isdn_divert.c
> @@ -442,7 +442,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
>   		switch (dv->rule.action) {
>   		case DEFLECT_IGNORE:
>   			return (0);
> -			break;
>
>   		case DEFLECT_ALERT:
>   		case DEFLECT_PROCEED:
> @@ -511,7 +510,6 @@ static int isdn_divert_icall(isdn_ctrl *ic)
>
>   		default:
>   			return (0); /* ignore call */
> -			break;

    You could have removed stupid () around 0, while at it.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html