netdev - Re: [PATCH 3.0-longterm] bonding: ARP packet fix for balance-ALB (mode=6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1364840061.3557.109.camel@deadeye.wl.decadent.org.uk>
Date:	Mon, 01 Apr 2013 19:14:21 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Matthew O'Connor <liquidhorse@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3.0-longterm] bonding: ARP packet fix for balance-ALB
 (mode=6)

On Mon, 2013-04-01 at 12:36 -0400, Matthew O'Connor wrote:
> Do not modify or load balance ARP packets passing through balance-alb
> mode (wherein the ARP did not originate locally, and arrived via a bridge).
> 
> This patch is backported from the upstream commit:
>     From 567b871e503316b0927e54a3d7c86d50b722d955 Mon Sep 17 00:00:00 2001
>     Subject: [PATCH] bonding: rlb mode of bond should not alter ARP
> originating via bridge
> 
> Signed-off-by:  Matthew O'Connor <liquidhorse@...il.com>
[...]

These patches are tab-damaged and word-wrapped.  See
Documentation/email-clients.txt

You should also use the conventional format for backported patches.
Keep the original commit message, but above it add:

    From: original author <address@...ain>

    commit 567b871e503316b0927e54a3d7c86d50b722d955 upstream.

The commit reference could also be written in David Miller's favoured
format:

    [ Upstream commit 567b871e503316b0927e54a3d7c86d50b722d955 ]

If you have made substantial changes then explain them at the end of the
commit message with clear attribution to yourself.  You could add some
explanation below the '---' of why this is important to include in a
stable update.

Lastly, this should be cc'd to all the addresses on the original commit
(From, Cc, and Signed-off-by).

Ben.

-- 
Ben Hutchings
DNRC Motto:  I can please only one person per day.
Today is not your day.  Tomorrow isn't looking good either.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)