netdev - question about kernel patch: ipv4: fix the rcu race between free_fib_info and ip_route_output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAOxq_8PTRwy6Rs+mM2gxViDoZpnCuT-KD3PkCC1i31XyT_VAkw@mail.gmail.com>
Date:	Tue, 2 Apr 2013 16:49:59 -0700
From:	Ani Sinha <ani@...stanetworks.com>
To:	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>
Cc:	Francesco Ruggeri <fruggeri@...stanetworks.com>,
	Bob Gilligan <gilligan@...stanetworks.com>,
	Prasad Koya <prasad@...stanetworks.com>
Subject: question about kernel patch: ipv4: fix the rcu race between
 free_fib_info and ip_route_output_slow

hello :

I was looking at the former netdev thread :
http://www.spinics.net/lists/netdev/msg193411.html

It seems the following patch was applied in Linux 3.5 to fix the oops
in ip_route_output_slow :

commit e49cc0da7283088c5e03d475ffe2fdcb24a6d5b1
Author: Yanmin Zhang <yanmin_zhang@...ux.intel.com>
Date:   Wed May 23 15:39:45 2012 +0000

    ipv4: fix the rcu race between free_fib_info and ip_route_output_slow

We hit into a very similar oops in the same place but with 2.6.38
kernel. We are thinking of backporting this patch to our 2.6.38 kernel
tree. Since I am not very familier with this code, I wanted to seek
the opinion of netdev folks and ask whether this will be safe to do
so. We did notice that this patch was backported to longterm supported
3.4 tree as well. We also notice that this patch was committed almost
one year back and has remained intact in Torvalds' latest and greatest
tip.

The patch itself looks simple enough but obviously we do not know the
code path well enough to understand all the impacts of this change.

Any suggestions will be greatly appreciated.

thanks,
ani
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html