netdev - RE: [PATCH net-next] bnx2x: handle spurious interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <979A8436335E3744ADCD3A9F2A2B68A52ABFCCF1@SJEXCHMB10.corp.ad.broadcom.com>
Date:	Tue, 2 Apr 2013 05:03:01 +0000
From:	"Yuval Mintz" <yuvalmin@...adcom.com>
To:	"Ben Hutchings" <bhutchings@...arflare.com>
cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Ariel Elior" <ariele@...adcom.com>,
	"Eilon Greenstein" <eilong@...adcom.com>
Subject: RE: [PATCH net-next] bnx2x: handle spurious interrupts

> >  void bnx2x_int_enable(struct bnx2x *bp)
> >  {
> > +	bp->flags |= INTERRUPTS_ENABLED_FLAG;
> > +
> 
> wmb();

Sure.

> 
> >  	if (bp->common.int_block == INT_BLOCK_HC)
> >  		bnx2x_hc_int_enable(bp);
> >  	else
> [...]

> > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> > @@ -866,6 +866,7 @@ static void bnx2x_int_disable(struct bnx2x *bp)
> >  		bnx2x_hc_int_disable(bp);
> >  	else
> >  		bnx2x_igu_int_disable(bp);
> 
> for (each interrupt vector)
> 	synchronize_irq(irq);
> 
> > +	bp->flags &= ~INTERRUPTS_ENABLED_FLAG;
> >  }

This was added mostly for completeness; We're unaware of any possible spurious interrupt after 
interrupts are disabled. Then again, as I'm about to re-send a modified version of this patch, I'll probably
introduce this change as well.

Thanks,
Yuval