netdev - re: GRE: Refactor GRE tunneling code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130402063421.GA4826@longonot.mountain>
Date:	Tue, 2 Apr 2013 09:34:21 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	pshelar@...ira.com
Cc:	netdev@...r.kernel.org
Subject: re: GRE: Refactor GRE tunneling code.

Hi Pravin,

I had a question about c54419321455: "GRE: Refactor GRE tunneling code."
from Mar 25, 2013:

net/ipv4/ip_gre.c
   392                  if (tpi->flags&TUNNEL_CSUM &&
   393                      !(skb_shinfo(skb)->gso_type & SKB_GSO_GRE)) {
   394                          *(__sum16 *)ptr = 0;
   395                          *(__sum16 *)ptr = csum_fold(skb_checksum(skb, 0,
   396                                                                   skb->len, 0));

What are we doing here when we set *ptr = 0 and then reset it on the
next line?  Is there a ptr++ or ptr-- missing?

   397                  }

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html