netdev - Re: Freescale FEC: fall back to random address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHrpEqSVUc1yedCoyOrRoxkjY7=N_pCDB1F7-WvRaP+4UEY68A@mail.gmail.com>
Date:	Tue, 2 Apr 2013 16:23:13 +0800
From:	Frank Li <lznuaa@...il.com>
To:	Pavel Machek <pavel@...x.de>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	fabio.estevam@...escale.com, l.stach@...gutronix.de,
	Frank.Li@...escale.com, netdev@...r.kernel.org
Subject: Re: Freescale FEC: fall back to random address

I think it is okay.

2013/4/1 Pavel Machek <pavel@...x.de>:
> If there's no valid ethernet address, fall back to randomly generated
> one.
>
> (Yes, I need to get newer u-boot for the board, but as the only
> available one is from 2009... this might be good idea).
>
> Signed-off-by: Pavel Machek <pavel@...x.de>
>
>
> index e3f3937..5a7d1e1 100644
> pp--- a/drivers/net/ethernet/freescale/fec.c
> +++ b/drivers/net/ethernet/freescale/fec.c
> @@ -906,6 +914,16 @@ static void fec_get_mac(struct net_device *ndev)
>                 iap = &tmpaddr[0];
>         }
>
> +       /*
> +        * 5) random mac address
> +        */
> +       if (!is_valid_ether_addr(iap)) {
> +               /* Report it and use a random ethernet address instead */
> +               netdev_err(ndev, "Invalid MAC address: %pM\n", iap);
> +               random_ether_addr(iap);
> +               netdev_info(ndev, "Using random MAC address: %pM\n", iap);
> +       }
> +
>         memcpy(ndev->dev_addr, iap, ETH_ALEN);
>
>         /* Adjust MAC if using macaddr */
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html