netdev - Re: [PATCH net-next] bridge: remove a redundant synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130402.121223.496337697838525487.davem@davemloft.net>
Date:	Tue, 02 Apr 2013 12:12:23 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...hat.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	stephen@...workplumber.org
Subject: Re: [PATCH net-next] bridge: remove a redundant synchronize_net()

From: Veaceslav Falico <vfalico@...hat.com>
Date: Tue, 2 Apr 2013 17:58:22 +0200

> On Tue, Apr 02, 2013 at 08:45:00AM -0700, Eric Dumazet wrote:
>>From: Eric Dumazet <edumazet@...gle.com>
>>
>>commit 00cfec37484761 (net: add a synchronize_net() in
>>netdev_rx_handler_unregister())
>>allows us to remove the synchronized_net() call from del_nbp()
>>
>>Signed-off-by: Eric Dumazet <edumazet@...gle.com>
 ...
> Acked-by: Veaceslav Falico <vfalico@...hat.com>

Applied.

Note that we have a few spots now that do two synchronize_net()'s per
opertaion, such as team port removal, and openvswitch has such a path
as well.  They all are of the form:

	netdev_rx_handler_unregister()
	...
	lots of other stuff
	...
	synchronize_net();

So might be harder to factor back out than this br_if.c case.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html