netdev - Re: [net-next.git 2/7] stmmac: review barriers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <515C3660.7000909@cogentembedded.com>
Date:	Wed, 03 Apr 2013 18:02:08 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
CC:	netdev@...r.kernel.org, Deepak Sikri <deepak.sikri@...com>,
	Shiraz Hashim <shiraz.hashim@...com>
Subject: Re: [net-next.git 2/7] stmmac: review barriers

Hello.

On 03-04-2013 9:41, Giuseppe CAVALLARO wrote:

> In all my tests performed on SH4 and ARM A9 platforms, I've never met problems
> that can be fixed by using memory barriers. In the past there was some issues
> on SMP ARM but fixed by reviewing xmit spinlock.

> Further barriers have been added in the commits too: 8e83989106562326bf

    Please also specify that commit's summary line in parens.

> This patch is to use the smp_wbm instead of wbm because the driver

    It's "wmb".

> runs on UP systems. Then, IMO it could make sense to only maintain the barriers
> just in places where we touch the dma owner bits (that is the
> only real critical path as we had seen and fixed in the commit:
> eb0dc4bb2e22c04964d).

   This one's too.

> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
> Cc: Deepak Sikri <deepak.sikri@...com>
> Cc: Shiraz Hashim <shiraz.hashim@...com>

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html