netdev - Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201304031455.47864.arnd@arndb.de>
Date:	Wed, 3 Apr 2013 14:55:47 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	balbi@...com
Cc:	Kishon Vijay Abraham I <kishon@...com>, gregkh@...uxfoundation.org,
	akpm@...ux-foundation.org, swarren@...dotorg.org,
	sylvester.nawrocki@...il.com, rob@...dley.net,
	netdev@...r.kernel.org, davem@...emloft.net, cesarb@...arb.net,
	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, tony@...mide.com,
	grant.likely@...retlab.ca, rob.herring@...xeda.com,
	b-cousson@...com, linux@....linux.org.uk, eballetbo@...il.com,
	javier@...hile0.org, mchehab@...hat.com, santosh.shilimkar@...com,
	broonie@...nsource.wolfsonmicro.com, swarren@...dia.com,
	linux-doc@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

On Wednesday 03 April 2013, Felipe Balbi wrote:
> const ? Maybe provide a:
> 
> #define DEFINE_PHY_OPS(name)    \
> const struct phy_ops #name_phy_ops = {
> 
> macro ? This will force people to add the const keyword :-)

Forcing people to use const structures is good, but I think it would be
better without the macro, just by marking the argument in 
devm_phy_create() as const.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html