[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 4 Apr 2013 07:00:40 -0700
From: Tejun Heo <htejun@...il.com>
To: Christoph Lameter <cl@...ux.com>
Cc: Eric Dumazet <eric.dumazet@...il.com>,
RongQing Li <roy.qing.li@...il.com>,
Shan Wei <davidshan@...cent.com>, netdev@...r.kernel.org
Subject: Re: [PERCPU] Remove & in front of this_cpu_ptr
Hello, Christoph.
On Thu, Apr 04, 2013 at 01:52:00PM +0000, Christoph Lameter wrote:
> The method that I proposed is also conforming with the use of other
> this_cpu_ops. F.e. In order to do a read one would need to do
>
> x = this_cpu_read(percpu_pointer->field)
>
>
>
>
> x = this_cpu_read(percpu_pointer)->field
>
> does not work (and does not pass sparse).
Right, this is true, and we *do* wanna support this_cpu ops other than
this_cpu_ptr on per-cpu struct fields. The usage is still somewhat
unusual tho. Can we please add documentation in the comments too?
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists