netdev - Re: [net-next 07/13] igb: random code and comments fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 04 Apr 2013 18:22:18 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC:	davem@...emloft.net,
	"Akeem G. Abodunrin" <akeem.g.abodunrin@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 07/13] igb: random code and comments fix

Hello.

On 04-04-2013 15:37, Jeff Kirsher wrote:

> From: "Akeem G. Abodunrin" <akeem.g.abodunrin@...el.com>

> This patch fixes code and comments as identified in the driver.

   It seems you are doing 3 different things in 3 different files in this 
patch... it would be better to split it up.

> Signed-off-by: Akeem G Abodunrin <akeem.g.abodunrin@...el.com>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
[...]

> diff --git a/drivers/net/ethernet/intel/igb/e1000_mac.c b/drivers/net/ethernet/intel/igb/e1000_mac.c
> index a5c7200..5d407f4 100644
> --- a/drivers/net/ethernet/intel/igb/e1000_mac.c
> +++ b/drivers/net/ethernet/intel/igb/e1000_mac.c
> @@ -1007,9 +1007,9 @@ s32 igb_config_fc_after_link_up(struct e1000_hw *hw)
>   		 * be asked to delay transmission of packets than asking
>   		 * our link partner to pause transmission of frames.
>   		 */
> -		else if ((hw->fc.requested_mode == e1000_fc_none ||
> -			  hw->fc.requested_mode == e1000_fc_tx_pause) ||
> -			 hw->fc.strict_ieee) {
> +		else if ((hw->fc.requested_mode == e1000_fc_none) ||
> +			 (hw->fc.requested_mode == e1000_fc_tx_pause) ||
> +			 (hw->fc.strict_ieee)) {

    The code was alright bnefore this change, so this isn't really a fix at 
all. Aside of that, () around == are not needed, and yet less around 
'hw->fc.strict_ieee'.

> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index fb162ef..8752f4f 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -3859,9 +3859,8 @@ static bool igb_thermal_sensor_event(struct e1000_hw *hw, u32 event)
>   		ctrl_ext = rd32(E1000_CTRL_EXT);
>
>   		if ((hw->phy.media_type == e1000_media_type_copper) &&
> -		    !(ctrl_ext & E1000_CTRL_EXT_LINK_MODE_SGMII)) {
> +		    !(ctrl_ext & E1000_CTRL_EXT_LINK_MODE_SGMII))
>   			ret = !!(thstat & event);
> -		}

    This was checkpatch.pl's message right?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html