netdev - Re: [PATCH] net: count hw_addr syncs so that unsync works properly.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130405.002004.1687390683331436879.davem@davemloft.net>
Date:	Fri, 05 Apr 2013 00:20:04 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vyasevic@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: count hw_addr syncs so that unsync works properly.

From: Vlad Yasevich <vyasevic@...hat.com>
Date: Tue,  2 Apr 2013 17:10:07 -0400

> A few drivers use dev_uc_sync/unsync to synchronize the
> address lists from master down to slave/lower devices.  In
> some cases (bond/team) a single address list is synched down
> to multiple devices.  At the time of unsync, we have a leak
> in these lower devices, because "synced" is treated as a
> boolean and the address will not be unsynced for anything after
> the fist device/call.
> 
> Treat "synced" as a count (same as refcount) and allow all
> unsync calls to work.
> 
> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>

Applied and queued up for -stable, thanks Vlad.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html