[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130407.164507.795222306786228518.davem@davemloft.net>
Date: Sun, 07 Apr 2013 16:45:07 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: romieu@...zoreil.com
Cc: hayeswang@...ltek.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next 1/8] r8169: Remove firmware code
From: Francois Romieu <romieu@...zoreil.com>
Date: Fri, 5 Apr 2013 01:42:29 +0200
> David Miller <davem@...emloft.net> :
> [...]
>> If so, should I just apply this series as-is ?
>
> Yes.
>
> - the series is imho -stable unfriendly: whoever wants to figure what
> should be fed into a -stable branch will have a hard time. :o/
> - the driver could had been more careful about firmware version/magic
> checks and firmware opcodes recycling. It's a bit late. It won't
> necessarily hurt.
> - there is a whole release cycle ahead to find problems - if any - due
> to the hw_start flow change. It seems sane.
> - the relative amount of binary like cruft is going down.
>
> I am not overflowed with enthusiasm but the gain should exceed the pain.
All applied to net-next, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists