[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130407.170433.1137459032889983595.davem@davemloft.net>
Date: Sun, 07 Apr 2013 17:04:33 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: amwang@...hat.com
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
david.ward@...mit.edu, jorge@...2.net
Subject: Re: [PATCH net-next] 802: fix a possible race condition
From: Cong Wang <amwang@...hat.com>
Date: Wed, 3 Apr 2013 15:52:40 +0800
> From: Cong Wang <amwang@...hat.com>
>
> (Resend with a better changelog)
>
> garp_pdu_queue() should ways be called with this spin lock.
> garp_uninit_applicant() only holds rtnl lock which is not
> enough here. A possible race can happen as garp_pdu_rcv()
> is called in BH context:
>
> garp_pdu_rcv()
> |->garp_pdu_parse_msg()
> |->garp_pdu_parse_attr()
> |-> garp_gid_event()
>
> Found by code inspection.
>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: David Ward <david.ward@...mit.edu>
> Cc: "Jorge Boncompte [DTI2]" <jorge@...2.net>
> Signed-off-by: Cong Wang <amwang@...hat.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists