netdev - Re: [patch 1/2] af_iucv: fix recvmsg by replacing skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365452192.3887.39.camel@edumazet-glaptop>
Date:	Mon, 08 Apr 2013 13:16:32 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	frank.blaschka@...ibm.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-s390@...r.kernel.org, Ursula Braun <ursula.braun@...ibm.com>
Subject: Re: [patch 1/2] af_iucv: fix recvmsg by replacing skb_pull()
 function

On Mon, 2013-04-08 at 10:19 +0200, frank.blaschka@...ibm.com wrote:
> plain text document attachment (601-af-iucv-skb-pull.diff)
> From: Ursula Braun <ursula.braun@...ibm.com>
> 
> When receiving data messages, the "BUG_ON(skb->len < skb->data_len)" in
> the skb_pull() function triggers a kernel panic.
> 
> Replace the skb_pull logic by a per skb offset as advised by
> Eric Dumazet.
> 
> Signed-off-by: Ursula Braun <ursula.braun@...ibm.com>
> Signed-off-by: Frank Blaschka <blaschka@...ux.vnet.ibm.com>
> Reviewed-by: Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>
> ---

This is indeed a nicer patch ;)

Acked-by: Eric Dumazet <edumazet@...gle.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html